ref(deploy): add domain to deploy output #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleN
commented
Jun 10, 2022
Cargo.toml
Outdated
| hippo-openapi = "0.5" | ||
| hippo = { git = "https://github.com/deislabs/hippo-cli"} | ||
| hippo-openapi = "0.8" | ||
| hippo = { path = "../hippo-cli"} |
There was a problem hiding this comment.
Needs to be updated when hippo-cli PR is merged deislabs/hippo-cli#141
Left here so anyone can easily test.
There was a problem hiding this comment.
I think this needs to be updated back?
michelleN
force-pushed
the
domain
branch
2 times, most recently
from
72edf7c
to
6e9287a
Compare
+ This commit adds the domain to the output if deploy was successful and the app type is http Co-authored-by Brian Hardock <brian.hardock@fermyon.com> Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
fibonacci1729
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the domain to the output if deploy was successful and the app type is http.
This PR depends on the following two changes:
Co-authored-by Brian Hardock brian.hardock@fermyon.com
Signed-off-by: Michelle Dhanani michelle@fermyon.com