Retain context of deploy push errors #601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a deployment fails due to a bindle push error (e.g. wrong URL), the error and immediate cause are printed on one line:
This PR proposes to use an
anyhow
context instead, which provides more formatting but also retains additional layers of context:I'm not sure if this much context is really right - I do think some measure of diagnostic info is good but this might be too "internal" looking for a user experience. In which case I'm happy to put it back to how it was before except with a newline grin.