-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unneeded explicit lifetime #613
Conversation
This should appease clippy and fix CI. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a few iterations of this code; I'm sure I just left these in accidentally.
@@ -148,7 +148,7 @@ dependencies = [ | |||
|
|||
[[package]] | |||
name = "spin-sdk" | |||
version = "0.2.0" | |||
version = "0.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional (in this PR)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a side effect of building. Perhaps someone made an earlier change but didn't check in Cargo.lock?
I can remove that from the commit and force-push, but I'm guessing it will pop up the next time anyone builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah seems fine to keep it, just making sure it wasn't accidentally pulled in from another change.
Oh right we just got a new rust release 👍 |
What's slightly confusing is that the referenced lint was apparently added in Rust 1.29.0 or earlier. Not sure why it's only complaining now. Perhaps the lint level was raised or the lint was expanded to cover more cases. |
This should appease clippy and fix CI.
Signed-off-by: Joel Dice joel.dice@fermyon.com