Fix crate unit tests not being run #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
approved these changes
Jul 14, 2022
|
Oh, DCO bot is unhappy. |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
test-all-the-things
branch
from
3eea681
to
9a63cc3
Compare
|
bumping DCO to Assistant Principal Arch-Nemesis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The makefile was reorganised to provide nice clearly separated unit and integration test targets, but in the process the
--allfell on the cutting room floor. So we are currently running only the tests for the bin, not the crates.I assume the
test-integrationtarget doesn't need the flag.(Also fixes a test failure that sneaked through when the tests weren't being fully run.)