fix: Terminate trigger handler on spin up termination
#642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
approved these changes
Jul 14, 2022
The `Ctrl-C` handler works because it is handled in the trigger handler child process, but if the parent `spin up` process is terminated instead - as with e.g. Nomad - the child is left running. Fix this by adding a signal handler to the parent process which sends SIGTERM to the child. Signed-off-by: Lann Martin <lann.martin@fermyon.com>
itowlson
reviewed
Jul 14, 2022
| let status = cmd.status().context("Failed to execute trigger")?; | ||
| let mut child = cmd.spawn().context("Failed to execute trigger")?; | ||
|
|
||
| #[cfg(not(windows))] |
There was a problem hiding this comment.
What happens if it is on Windows?
There was a problem hiding this comment.
What happens on windows today? 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Ctrl-Chandler works because it is handled in the trigger handlerchild process, but if the parent
spin upprocess is terminatedinstead - as with e.g. Nomad - the child is left running.
Fix this by adding a signal handler to the parent process which sends
SIGTERM to the child.
I expect this to fix #638