Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename top-level config section to variables #652

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

fibonacci1729
Copy link
Contributor

@fibonacci1729 fibonacci1729 commented Jul 19, 2022

This PR renames the top-level config section in the spin.toml to variables.
Updates the examples and documentation.

NOTE: This is a breaking change.

Signed-off-by: Brian H brian.hardock@fermyon.com

@fibonacci1729 fibonacci1729 marked this pull request as ready for review July 19, 2022 16:14
@fibonacci1729 fibonacci1729 requested a review from lann July 19, 2022 16:15
@lann
Copy link
Collaborator

lann commented Jul 19, 2022

Update docs?

@fibonacci1729 fibonacci1729 force-pushed the rename-config-to-vars branch 2 times, most recently from 4b44839 to 9e6d6f6 Compare July 19, 2022 17:00
This PR renames the top-level config section in the spin.toml to variables
and updates the examples.

NOTE: This is a breaking change.

Signed-off-by: Brian H <brian.hardock@fermyon.com>
@fibonacci1729 fibonacci1729 merged commit 76dbc19 into fermyon:main Jul 19, 2022
@fibonacci1729 fibonacci1729 deleted the rename-config-to-vars branch July 19, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants