Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(outbound-redis): add incr #671

Merged
merged 2 commits into from
Aug 5, 2022
Merged

feat(outbound-redis): add incr #671

merged 2 commits into from
Aug 5, 2022

Conversation

FrankYang0529
Copy link
Contributor

@FrankYang0529 FrankYang0529 commented Aug 2, 2022 •
edited
Loading

resolves #668

Run rust-outbound-redis for testing:

> cargo build
> cd examples/rust-outbound-redis
> ../../target/debug/spin build
> ../../target/debug/spin up
> curl -i http://127.0.0.1:3000/publish
HTTP/1.1 200 OK
content-length: 0
date: Thu, 04 Aug 2022 15:20:13 GMT

@FrankYang0529 FrankYang0529 marked this pull request as ready for review August 4, 2022 15:20
fibonacci1729
fibonacci1729 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@fibonacci1729 fibonacci1729 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FrankYang0529 ! LGTM.

It appears that all your commits are not signed but once you do that, we can merge 🚀

@FrankYang0529
feat(outbound-redis): add incr
177c411 
Signed-off-by: Frank Yang <yangpoan@gmail.com>
@FrankYang0529
feat(examples/rust-outbound-redis): add incr
bba756a 
Signed-off-by: Frank Yang <yangpoan@gmail.com>
@FrankYang0529
Copy link
Contributor Author

It appears that all your commits are not signed but once you do that, we can merge 🚀

Updated it. Thank you.

@fibonacci1729 fibonacci1729 merged commit 621ff21 into fermyon:main Aug 5, 2022
@FrankYang0529 FrankYang0529 deleted the add-redis-incr branch August 6, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fibonacci1729 fibonacci1729 fibonacci1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add increment function in outbound Redis implementation
2 participants
@FrankYang0529 @fibonacci1729