-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feature gate the e2e tests that require dependencies #681
feat: feature gate the e2e tests that require dependencies #681
Conversation
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great for me when I run locally! My only suggested change is to add a make test-e2e
line to https://github.com/fermyon/spin/blob/main/.github/workflows/build.yml#L124-L129 now that we have a new target for these.
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
The clippy errors are due to the rust toolchain being updated. I fixed it as part of #684 Edit: That's merged now, so updating this from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kate, this looks great! 🎉
Thank you @vdice. Essential step i missed. Replaced |
Moves e2e integration tests that require dependencies behind an
e2e-tests
feature, so the dependencies (bindle-server
,nomad
andHippo.Web
) do not need to be installed to runmake test
ormake test-integration
.Running
make test-e2e
will run all tests including ones with dependencies (after checking the dependencies exist).fixes #626
Signed-off-by: Kate Goldenring kate.goldenring@fermyon.com