Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feature gate the e2e tests that require dependencies #681

Merged

Conversation

kate-goldenring
Copy link
Contributor

Moves e2e integration tests that require dependencies behind an e2e-tests feature, so the dependencies (bindle-server, nomad and Hippo.Web) do not need to be installed to run make test or make test-integration.

Running make test-e2e will run all tests including ones with dependencies (after checking the dependencies exist).

fixes #626

Signed-off-by: Kate Goldenring kate.goldenring@fermyon.com

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for me when I run locally! My only suggested change is to add a make test-e2e line to https://github.com/fermyon/spin/blob/main/.github/workflows/build.yml#L124-L129 now that we have a new target for these.

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@lann
Copy link
Collaborator

lann commented Aug 11, 2022

The clippy errors are due to the rust toolchain being updated. I fixed it as part of #684

Edit: That's merged now, so updating this from main should fix that CI error.

Copy link
Contributor

@fibonacci1729 fibonacci1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kate, this looks great! 🎉

@kate-goldenring
Copy link
Contributor Author

This works great for me when I run locally! My only suggested change is to add a make test-e2e line to https://github.com/fermyon/spin/blob/main/.github/workflows/build.yml#L124-L129 now that we have a new target for these.

Thank you @vdice. Essential step i missed. Replaced make test-integration with make test-e2e in 3981763

@kate-goldenring kate-goldenring merged commit f57cf9f into fermyon:main Aug 11, 2022
@kate-goldenring kate-goldenring deleted the feature-gate-e2e-tests-with-deps branch August 11, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test: Feature gate the e2e tests
4 participants