feat: add accept-defaults to new templates #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
force-pushed
the
feat/accept-defaults
branch
2 times, most recently
from
0f62200
to
d5a88ea
Compare
radu-matei
reviewed
Aug 18, 2022
itowlson
requested changes
Aug 18, 2022
There was a problem hiding this comment.
Thanks for taking this on. I'd strongly encourage you to dive a little deeper into the templates crate - although it requires more code reading, I believe you'll end up at an existing function where the code has both the parameter object and designated value to hand, and is performing the existing "value > prompt" logic. Extending that to "value > accepted default > prompt" should (I hope) be a couple of lines.
Happy to chat or pair I'm not explaining myself well...
itowlson
reviewed
Aug 18, 2022
karthik2804
force-pushed
the
feat/accept-defaults
branch
from
d5a88ea
to
34ad313
Compare
itowlson
requested changes
Aug 18, 2022
Signed-off-by: karthik Ganeshram <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
feat/accept-defaults
branch
from
34ad313
to
1987881
Compare
radu-matei
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional argument
--accept-defaultstospin newto accept defaults where available from the template. The values file and value mentioned in the CLI still take precedence.closes #591.