Add HTTP TooManyRequests error #719
Conversation
Signed-off-by: Brian H <brian.hardock@fermyon.com>
| @@ -58,4 +58,5 @@ enum http-error { | |||
| invalid-url, | |||
| request-error, | |||
| runtime-error, | |||
| too-many-requests, | |||
| } | |||
There was a problem hiding this comment.
Do you remember why we had to duplicate the .wits over here?
There was a problem hiding this comment.
Not at the moment, off the cuff it had something to do with the macro crate not being able to access the workspace root by specifying a relative path from the manifest dir (i.e. CARGO_MANIFEST_DIR).
In other words, the code that gets generated would contain something like (which wasn't valid):
include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/../..wit/spin-http.wit")));
Where CARGO_MANIFEST_DIR points to the macro crate.
| @@ -55,4 +55,5 @@ enum http-error { | |||
| invalid-url, | |||
| request-error, | |||
| runtime-error, | |||
| too-many-requests, | |||
There was a problem hiding this comment.
Just a reminder that this can be a breaking change. I don't see us doing explicit matching on these anywhere in our repos tho, so probably fine.
Aside: it would nice if wit-bindgen had a "non-exhaustive" annotation to emit e.g. Rust's #[non_exhaustive]
Signed-off-by: Brian H brian.hardock@fermyon.com