Stop using WASI HTTP params in preparation for deprecation #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested and confirmed that the Rust SDK now behaves correctly when there is a URI containing query strings. I tested by building Bartholomew & handlebars-sprig against the SDK to test the tweeting functionality. |
radu-matei
reviewed
Aug 30, 2022
radu-matei
approved these changes
Aug 30, 2022
lann
reviewed
Aug 30, 2022
| @@ -70,6 +70,10 @@ impl wasi_outbound_http::WasiOutboundHttp for OutboundHttp { | |||
| let headers = request_headers(req.headers)?; | |||
| let body = req.body.unwrap_or_default().to_vec(); | |||
|
|
|||
| if !req.params.is_empty() { | |||
| tracing::log::warn!("HTTP params field is deprecated"); | |||
lann
approved these changes
Aug 30, 2022
radu-matei
approved these changes
Aug 30, 2022
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
deprecate-http-params
branch
from
04e9b41
to
130815c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #663.
What this PR does:
paramsfield is no longer populated when passed to the guest module. (It is set to an empty vector instead.) As far as I can tell, this should have no impact since the Rust and Go SDKs both appear to consume only theuri, and any query string APIs operate on that not on theparamscollection.http::RequestURI into WASIuriandparams. The URI is stringised and preserved intact, andparamsis set to an empty vector. This should mean the Rust SDK now behaves correctly when the request URI contains a query string but I am not sure where I can test this.paramsanywhere in the code - I assume it already passed through URIs with query strings unaltered. Again not sure where to put a test for this.@adamreese can you take a look and confirm that no changes are needed to the Go SDK please? Thanks!
Signed-off-by: itowlson ivan.towlson@fermyon.com