Simplify spin-config implementation #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
force-pushed
the
simplify-config
branch
from
05aa50a
to
6f6fe4c
Compare
lann
force-pushed
the
simplify-config
branch
from
6f6fe4c
to
2f06812
Compare
- Replace the recursive tree structure with flat variables and per-component config maps. - Decouple config from spin-engine, turning it into a normal HostComponent. Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
simplify-config
branch
from
2f06812
to
763387f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337
Ref #714 (expressions are now checked for defined variable names)
Fixes #718