Deduplicate some spin-testing code #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etehtsea FYI |
The test configs were just split into http and redis variants. This follow-up reduces duplicated code between those. Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
dedup-test-configs
branch
from
676084f
to
7d149f2
Compare
I wasn't sure that my PR is "the right way" to fix it. |
radu-matei
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test configs were just split into http and redis variants. This follow-up reduces duplicated code between those.
Signed-off-by: Lann Martin lann.martin@fermyon.com