command(login): validate that the provided hippo URL is valid #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endocrimes
force-pushed
the
dani/validate-hippo-url
branch
from
e238c1b
to
81f7d21
Compare
lann
reviewed
Oct 18, 2022
endocrimes
force-pushed
the
dani/validate-hippo-url
branch
from
81f7d21
to
5707550
Compare
endocrimes
force-pushed
the
dani/validate-hippo-url
branch
2 times, most recently
from
cf0cb26
to
a2b950a
Compare
Signed-off-by: Danielle Lancashire <dani@builds.terrible.systems>
endocrimes
force-pushed
the
dani/validate-hippo-url
branch
from
a2b950a
to
a2b12ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea what the "idomatic rust" way to do this is, so I'm going vaguely based on how we return errors elsewhere in the
logincommand.Previous behavior:
One would be prompted to choose an auth method before then receiving a
reqwesterror.New behavior:
Happy to workshop on the error message itself (and if you point me to where integration testing happens I'm happy to add a regression test).
Signed-off-by: Danielle Lancashire dani@builds.terrible.systems