move hashtables to end of toml-serializable structs #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
approved these changes
Oct 19, 2022
This is needed to avoid "value must be emitted before tables" errors when serializing to TOML. I don't believe Spin itself ever serializes these structs to TOML, but other libraries may want to reuse `spin-loader` and do so. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
force-pushed
the
toml-serialization
branch
from
ee9487c
to
bae58a1
Compare
lann
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to avoid "value must be emitted before tables" errors when serializing to TOML.
I don't believe Spin itself ever serializes these structs to TOML, but other libraries may want to reuse
spin-loaderand do so.Signed-off-by: Joel Dice joel.dice@fermyon.com