Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak spin deploy output #839

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Tweak spin deploy output #839

merged 1 commit into from
Oct 20, 2022

Conversation

lann
Copy link
Collaborator

@lann lann commented Oct 20, 2022 •
edited
Loading

The main thing this adds is a Uploading... message immediately after running spin deploy just to give quicker feedback.

Before:

$ spin deploy
[...no output until things are done...]
Deployed fermyon-com version 0.3.0+q7bdd566
Waiting for application to become ready............. ready

After:

$ spin deploy
Uploading...
Deploying fermyon-com version 0.3.1+q8c7dfa0 ...
Waiting for application to become ready... ready

^ first message is immediate

@lann
Tweak spin deploy output
050fdd1 
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann requested review from itowlson, bacongobbler, michelleN and mikkelhegn and removed request for itowlson and bacongobbler October 20, 2022 16:42
@lann lann merged commit e59b295 into fermyon:main Oct 20, 2022
@lann lann deleted the tweak-deploy-output branch October 20, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fibonacci1729 fibonacci1729 fibonacci1729 approved these changes

@itowlson itowlson Awaiting requested review from itowlson

@michelleN michelleN Awaiting requested review from michelleN

@mikkelhegn mikkelhegn Awaiting requested review from mikkelhegn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lann @fibonacci1729