Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify spin deploy output #847

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Simplify spin deploy output #847

merged 1 commit into from
Oct 21, 2022

Conversation

lann
Copy link
Collaborator

@lann lann commented Oct 21, 2022 •
edited
Loading

Per discussion in slack; we didn't come to this conclusion collectively, its just my suggestion.

Currently the output is either:

Uploading...
Deploying cloud_start version 0.1.0+ra0494a20 ...
Waiting for application to become ready....... ready

or

Uploading...
Uploading application to <url>
Deploying cloud_start version 0.1.0+ra0494a20 ...
Waiting for application to become ready....... ready

Depending on how long uploading takes.

This simplifies the output to:

Uploading spin-hello-world version 1.0.0+r19e7b25a...
Deploying...
Waiting for application to become ready... ready

(unconditional)

@lann
Simplify spin deploy output
c6e8ca0 
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann merged commit 695bcce into fermyon:main Oct 21, 2022
@lann lann deleted the simplify-deploy-output branch February 16, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fibonacci1729 fibonacci1729 fibonacci1729 approved these changes

@itowlson itowlson Awaiting requested review from itowlson

@mikkelhegn mikkelhegn Awaiting requested review from mikkelhegn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lann @fibonacci1729