-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates for static fileserver and redirect #898
Conversation
bea9295
to
5a55bf7
Compare
5a55bf7
to
bd98a17
Compare
Wondering if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have only review the template metadata.
|
||
[parameters] | ||
http-path = { type = "string", prompt = "HTTP path", default = "/static/...", pattern = "^/\\S*$" } | ||
asset-path = { type = "string", prompt = "Directory containing static assets to serve", default = "assets", pattern = "^\\S+$" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to change this to "files-path" with a prompt "Directory containing the files to serve."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - thanks!
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
bd98a17
to
a5c37a0
Compare
This depends on #889 (and currently includes it; I'll rebase once we've agreed whether that's the way to go and have merged whatever comes out of the discussion).
At the moment the component references refer to test releases in my forks. I will update these when we do formal releases.