Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(GitHub): Refactor build/test workflow #904

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

endocrimes
Copy link
Member

@endocrimes endocrimes commented Nov 16, 2022

Our current builds are currently unstable because we run out of disk
space on the default GitHub Actions builders.

While we could start trying to be clever and purge various resources
between steps - it's simpler to refactor the build into mutliple
independent steps.

For now we're going to use a "shared-for-the-platform" cache based on
the hash of the Cargo.lock. I plan to follow up with a little more
rigerous of a cache-key system that can also naturally expire a little
sooner to ensure everything is still buildable - but for now, lets get
spin building consistently again.

@endocrimes endocrimes force-pushed the dani/test-workflow branch 7 times, most recently from 6935306 to 3d5019d Compare November 16, 2022 23:02
Our current builds are currently unstable because we run out of disk
space on the default GitHub Actions builders.

While we could start trying to be clever and purge various resources
between steps - it's simpler to refactor the build into mutliple
independent steps.

For now we're going to use a "shared-for-the-platform" cache based on
the hash of the Cargo.lock. I plan to follow up with a little more
rigerous of a cache-key system that can also naturally expire a little
sooner to ensure everything is still buildable - but for now, lets get
spin building consistently again.

Signed-off-by: Danielle Lancashire <dani@builds.terrible.systems>
@endocrimes endocrimes changed the title wip: Testing actions refactor chore(GitHub): Refactor build/test workflow Nov 17, 2022
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thank you for the fix!

LGTM

@endocrimes endocrimes merged commit 903a1d5 into fermyon:main Nov 17, 2022
@endocrimes endocrimes deleted the dani/test-workflow branch November 17, 2022 12:04
@vdice vdice mentioned this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants