Fail if template references unknown filter #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
force-pushed
the
templates-fail-better
branch
5 times, most recently
from
a1a6205
to
c7305f4
Compare
dicej
approved these changes
Nov 29, 2022
crates/templates/src/renderer.rs
Outdated
| let err_lines = err_str.lines().collect_vec(); | ||
|
|
||
| // They should use typed errors like we, er, don't | ||
| match err_lines.first() { |
There was a problem hiding this comment.
Nit: no need to collect the lines into a Vec if you only care about the first one.
Suggested change
| match err_lines.first() { | |
| match err_str.lines().next() { |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
templates-fail-better
branch
from
c7305f4
to
d54f99a
Compare
kate-goldenring
approved these changes
Nov 29, 2022
fibonacci1729
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template system is intentionally forgiving of parse errors, because a template might contain text that confuses the Liquid parser but which an author wants to be included anyway. However, this can disguise genuine authoring errors. This particular one bit me when accidentally using the redirect template with a previous version of Spin - it appeared to succeed but actually failed on a new filter and dumped the unsubstituted template into my project. With this fix, I need never be confused again.
Longer term, we perhaps need more robust mechanisms for template authors to exclude files from parsing, after which we can banhammer actual parse failures.
Signed-off-by: itowlson ivan.towlson@fermyon.com