Skip validating unused manifest fields in spin build #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
build-less-stroppy-about-validation
branch
from
f0585ff
to
3eb23f3
Compare
dicej
approved these changes
Nov 28, 2022
|
Will accept any review with the word 'egregious' in it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #473.
The approach taken here is that we don't care if other parts of the manifest are valid, as long as we have the info we need to do the build. In terms of the original issue, the build won't fail because you have a missing field in your trigger. The downside of this is that it results in some duplication of the parts of the manifest schema.
An alternative approach would be to keep the existing loader but just improve the error reporting around manifest load failures. Despite the duplication, I prefer skipping validation, because if I'm in coding flow I don't want to have to take time out to fix some random other field. But happy to have that discussion.
Signed-off-by: itowlson ivan.towlson@fermyon.com