Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is not async #925

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Build is not async #925

merged 1 commit into from
Nov 30, 2022

Conversation

itowlson
Copy link
Contributor

Some internals of the build crate were declared as async and had machinery to run in parallel. From what I can tell, they never have been async, so the parallelism/join stuff wasn't doing anything - the builds have always been sequential. The presence of async may be a hangover from during initial development (perhaps the author started out by using tokio::process::Command?).

This PR removes the async modifier and strips out the machinery for joining after parallel builds.

Signed-off-by: itowlson ivan.towlson@fermyon.com

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

I think the desired behavior is for component build steps to run sequentially anyway, so this makes sense.

LGTM

@itowlson
Copy link
Contributor Author

Yes, they print build output as they go, and it would be super confusing to have multiple component build outputs overlapping...!

@itowlson itowlson merged commit c368fce into fermyon:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants