Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some internals of the
build
crate were declared as async and had machinery to run in parallel. From what I can tell, they never have been async, so the parallelism/join stuff wasn't doing anything - the builds have always been sequential. The presence ofasync
may be a hangover from during initial development (perhaps the author started out by usingtokio::process::Command
?).This PR removes the
async
modifier and strips out the machinery for joining after parallel builds.Signed-off-by: itowlson ivan.towlson@fermyon.com