Fix spin up --help omitting many options if app is not ready to lock
#934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
approved these changes
Dec 5, 2022
src/commands/up.rs
Outdated
Comment on lines
159
to
160
| let help_args = vec![OsString::from("--help-args-only")]; | ||
| cmd.args(help_args); |
There was a problem hiding this comment.
Can simplify since it doesn't have to match the type of trigger_args:
Suggested change
| let help_args = vec![OsString::from("--help-args-only")]; | |
| cmd.args(help_args); | |
| cmd.arg("--help-args-only"); |
src/commands/up.rs
Outdated
| @@ -199,6 +188,25 @@ impl UpCommand { | |||
| } | |||
| } | |||
|
|
|||
| fn build_locked_app( | |||
There was a problem hiding this comment.
Maybe?
Suggested change
| fn build_locked_app( | |
| fn write_locked_app( |
Comment on lines
+1089
to
+1096
| name = "unbuilt" | ||
| trigger = { type = "http", base = "/" } | ||
| version = "0.1.0" | ||
| [[component]] | ||
| id = "unbuilt" | ||
| source = "DOES-NOT-EXIST.wasm" | ||
| [component.trigger] | ||
| route = "/..." |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
up-help-when-app-not-ready-to-lock
branch
from
4502cc8
to
06d1c15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #932.
There remains an outstanding issue where
spin up --helpwill skip "trigger" arguments if the app contains no components. This happens because the serialisation objects makecomponenta mandatory field, so we cannot even load the file in this case. This could be addressed by makingcomponentoptional, and validating that at least one component exists during the locking process (or otherwise after the initial load). This is probably a bit of a niche case though.Signed-off-by: itowlson ivan.towlson@fermyon.com