Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contributing link in README.md #961

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

morristai
Copy link
Contributor

Since the link in the README.md is broken, the contributing link should now direct to the Fermyon contributing page.
image

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's embarrassing. Thanks for tracking it down and taking the time to fix it!

@itowlson
Copy link
Contributor

Sorry, I'm afraid we need the commit to be signed, both with a Git "signed off by" and a GPG key (verified commit). Could you do those and re-push please? Thanks!

Signed-off-by: Morris Tai <morristai01@gmail.com>
@morristai
Copy link
Contributor Author

Sorry, I'm afraid we need the commit to be signed, both with a Git "signed off by" and a GPG key (verified commit). Could you do those and re-push please? Thanks!

Done!

Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for catching this!

LGTM

@radu-matei radu-matei merged commit b96e5cd into fermyon:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants