feat: add aliases for plugin and templates subcommands for plurality #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
|
Thanks for this! Could you run |
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
itowlson
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
LGTM - thanks!
@kate-goldenring Do you think we should rationalise it so that both commands have the same "default" plurality (with the aliases so both forms are accepted regardless)? I don't have a particular view, just raising it for discussion.
|
@itowlson this is a good point. In aim of consistency, we could switch all references of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aliases to
pluginandtemplatessubcommandsIssue #942
Signed-off-by: Raymundo Vásquez Ruiz raymundo.vr@protonmail.com