Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render error snippet without json wrapper #1647

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Oct 10, 2024

errors was previously rendered form ErrorsV1, but when we switched to ErrorsV2, ErrorsV2 nested the value in the following way:

{
  "type": "json",
  "value": "my-value"
}

this pr changes it to render:

"my-value"

@dsinghvi dsinghvi merged commit 912cb55 into main Oct 10, 2024
19 checks passed
@dsinghvi dsinghvi deleted the ajiang/fix-error-snippet branch October 10, 2024 22:00
Copy link

Playwright test results

passed  1 passed

Details

stats  1 test across 1 suite
duration  9 seconds
commit  0589c6a

Copy link

PR Preview

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 162.69 KB (🟢 -94.59 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/404 332 B 163.01 KB 46.58%
/dynamic/[domain]/[[...slug]] 52.7 KB 215.39 KB 61.54%
/static/[domain]/[[...slug]] 52.7 KB 215.39 KB 61.54%

Copy link

Playwright test results

passed  81 passed

Details

stats  81 tests across 3 suites
duration  1 minute, 13 seconds
commit  0589c6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants