Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding validation #19

Closed
dsinghvi opened this issue Apr 13, 2022 · 12 comments
Closed

Adding validation #19

dsinghvi opened this issue Apr 13, 2022 · 12 comments

Comments

@dsinghvi
Copy link
Member

Creating issue where we can jot down all validations we have to add:
@dsinghvi
Copy link
Member Author

Enum values are unique

@zachkirsch
Copy link
Contributor

ids are unique

@dsinghvi
Copy link
Member Author

void types cannot be used for httpRequest body types

@dsinghvi
Copy link
Member Author

Validate POST/PUT has request/response, DELETE/PATCH has no response, GET has no request

@dsinghvi
Copy link
Member Author

Validate that namedTypes are actually defined

@dsinghvi dsinghvi added the P1 label Apr 22, 2022
@dsinghvi
Copy link
Member Author

No optional<optional>

@dannysheridan
Copy link
Member

Is this related to #67 ?

@dannysheridan
Copy link
Member

Is this related to #133 ?

@zachkirsch
Copy link
Contributor

@dannysheridan yes they are all the same

@dannysheridan
Copy link
Member

Related to #102 as well

@zachkirsch
Copy link
Contributor

Example of adding a rule: #357

@dannysheridan dannysheridan removed the P1 label Jul 29, 2022
@dannysheridan dannysheridan mentioned this issue Jul 29, 2022
Closed
@dannysheridan
Copy link
Member

separated these out into their own issues.

dsinghvi pushed a commit that referenced this issue Jan 21, 2024
@zachkirsch
Simplify import constraints, start using declaration's referencedTypes (
052cf0f 
#19)

* Fix issue with top imports

* Simplify import constraints
dsinghvi added a commit that referenced this issue Jan 24, 2024
@dsinghvi @zachkirsch
improvement: upgrade versions in package.json (#19)
42b3b24 
* upgrade versions in package.json

* try compile

* repro esm issue

* Fix jest

* Remove unused deps

* Fix jest

Co-authored-by: Zach Kirsch <zachkirsch@gmail.com>
dsinghvi added a commit that referenced this issue Feb 3, 2024
@dsinghvi
fix: misc fixes for medplum model generation (#19)
3621c52 
* handle discriminators and fix compile breaks

* spotless

* spotless apply

* fix imports

* check actually works

* medplum changes

* misc fixes so that medplum model can be generated

* test is back to fern ir

* spotless
dsinghvi pushed a commit that referenced this issue Feb 9, 2024
@dannysheridan
Add contributing guide (#19)
b0cc69e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zachkirsch @dsinghvi @dannysheridan