Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameters to path-parameters #44

Closed
dsinghvi opened this issue Apr 17, 2022 · 1 comment
Closed

Rename parameters to path-parameters #44

dsinghvi opened this issue Apr 17, 2022 · 1 comment

Comments

@dsinghvi
Copy link
Member

dsinghvi commented Apr 17, 2022

I think the yaml is cleaner when it reads like

storeTracedWorkspaceV2:
        http: POST /store-workspace-trace-v2/submission/{submissionId}
        path-parameters:
          submissionId: submission.SubmissionId
        query-parameters:
          stuff: Stuff
        body: list<submission.TraceResponseV2>

as opposed to

storeTracedWorkspaceV2:
        http: POST /store-workspace-trace-v2/submission/{submissionId}
        parameters:
          submissionId: submission.SubmissionId
        query-parameters:
          stuff: Stuff
        body: list<submission.TraceResponseV2>
@dannysheridan
Copy link
Member

Change made.

Example:

getMovie:
          method: GET
          path: /{movieId}
          path-parameters:
            movieId: MovieId

dsinghvi added a commit that referenced this issue Jan 21, 2024
* consume generator_exec_client

* fix test

* fix mypy

* fix pre-commit

* use generator exec wrapper to broadcast statuses

* use visitor

* fix mypy
dsinghvi added a commit that referenced this issue Jan 22, 2024
dsinghvi added a commit that referenced this issue Feb 3, 2024
* rename jersey codegen to jersey client codegen

* setup jersey-server-codegen project

* package rename

* generate servers

* add basic service gen tests

* test

* fix check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants