(feat, csharp): support sending bytes requests #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +38,7 @@ export class EndpointGenerator { | |||
| endpoint: HttpEndpoint; | |||
| rawClientReference: string; | |||
| }): csharp.Method { | |||
| console.log(`Generating endpoint id ${endpoint.id}`); | |||
There was a problem hiding this comment.
nit: should this use the generator exec context logger? or should it be removed?
There was a problem hiding this comment.
should be removed, my b
armandobelardo
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design for this in the SDK is:
bytesparameters are typed asStreamso that users can pass in a file stream, byte stream, in memory byte stream, etc.JsonApiRequestor aStreamApiRequestas input so each endpoint can pass in what they want