necinnost: DP children born in CZ, nezletile, vady zadosti + some minor fixes #12
Conversation
There was a problem hiding this comment.
Thanks a lot for the pr, that's a real valuable case I have overlooked.
This would require some additional client-side support that I have been postponing for ages (#13), I have put it on my to-do list.
| @@ -177,7 +179,7 @@ def generate(): | |||
| docx_template_name = TEMPLATE_MAP.get(form_name, {}).get('template') | |||
| context_name = TEMPLATE_MAP.get(form_name, {}).get('context') | |||
| if not docx_template_name or not context_name: | |||
| raise ConfigError("No routing specified for {}".format(form_name)) | |||
| raise exc.ConfigError("No routing specified for {}".format(form_name)) | |||
There was a problem hiding this comment.
Thanks, looks like my linter has broken down
| @@ -88,6 +158,44 @@ document: | |||
| - name: application_date | |||
| default: "01.01.11" | |||
| type: date | |||
|
|
|||
| - name: vady_zadosti_checkbox | |||
There was a problem hiding this comment.
That's a great idea to consider the request for additional documents, thanks.
But this makes calculating the deadline trickier (the N days decision process is stopped the very day a request for additional documents is sent out for at least 15 days\until the additional documents are delivered) and needs fixing the docx template appropriately as when the documents are requested the process is actually 'zakonne prerusen'.
There was a problem hiding this comment.
Yeah, but what I meant here is that the field "vady_zadosti_resolution_date" is the date when "vady zadosti byli odstraneny" by you. For example, you personally came to the MIA office and brought them the requested by "vyzva k odstraneni vad zadosti" document, so at that moment "vady zadosti byli odstraneny" and the process became active again, but I'm not sure that's correct...
| default: "01.02.2021" | ||
| type: date | ||
|
|
||
| - name: nezletily_checkbox |
There was a problem hiding this comment.
Another great idea, but this will require some long-planned client-side changes, as that is a corner case which will leave the original form too cluttered if not shown on demand.
I will come with a way (by introducing new type and processing it by j2 templates/javascript accordingly?) to include fields that will be shown only if the user checks a checkbox. That type then could be used in 'vady_zadosti-' and 'nezletily-' fields.
There was a problem hiding this comment.
Yeah, the form became too messy, that's for sure. Definitely, it would be nice to have the fields shown only under the checkboxes
| DV: | ||
| name: "Dlouhodobé vízum" | ||
| deadline: "90 dnů ode dne podání žádosti, nebo 120 dnů ve zvlášť složitých případech" | ||
| deadline: "90 dnů ode dne podání žádosti (odstranění vad žádosti) nebo 120 dnů ve zvlášť složitých případech" |
There was a problem hiding this comment.
It's unfortunately more complicated, once a 'odstraneni vad zadosti' request is sent the N days countdown stops. So I'd rather leave there the original version.
There was a problem hiding this comment.
The same here, I meant the date when "vady zadosti byli odstraneny" - ode dne odstraneni vad zadosti
| - True | ||
| type: radio | ||
|
|
||
| - name: nezletily_name |
There was a problem hiding this comment.
See comment above, I will have to add the client-side support for on-demand showing\hiding group of fields not to clutter the form with too much info.
But a great addition, thanks!
Checkbox type (rename to control-checkbox?) is a special type that let's control if a specific related form field will be shown on client-side. Nezletily has been refactored into the checkbox, now all nezletily-* fields won't be shown unless this checkbox is checked. Closes: fernflower#13
Introduced checkbox type & conditional client fields
There was a problem hiding this comment.
Sorry for taking so long - I have finally implemented the client-side hiding (#13), this will be done if you mark the field in context with the type: checkbox.
Could you please rebase against master? There is likely to be a conflict in data/contexts/necinnost_Nin1_context.yaml as I have already fixed the nezletily field to make an example how the new type should be used (but the vady_zadosti still remain to be changed).
Thank you!
…eature/necinnostupdates # Conflicts: # data/application_templates/zadost_o_uplatneni_opatreni_proti_necinnosti_spravniho_organu_Nin1.docx # data/contexts/necinnost_Nin1_context.yaml
|
Looks good, thank you! I added the checkbox for vady zadosti as well |
|
Deployed at production, thanks! |
for necinnost: