Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests for #303 (unreleased) #341

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Jan 23, 2024

Fixes the failing tests introduced in #303. Since the Buffer was 4 bytes long these comparisons couldn't ever work before.

@junderw
Copy link
Contributor

junderw commented Jan 23, 2024

This is incorrect.

We expect the buffer to be 1 byte.

@LinusU
Copy link
Contributor Author

LinusU commented Jan 23, 2024

This is incorrect.

We expect the buffer to be 1 byte.

This is doing .write to a Buffer that is already 4 bytes long. write cannot truncate the buffer so the buffer will still be 4 bytes...

@LinusU
Copy link
Contributor Author

LinusU commented Jan 23, 2024

(failing CI adressed in #342)

@dcousens
Copy link
Collaborator

@LinusU can you rebase this?

@dcousens dcousens changed the title Fix failing tests Fix failing tests for #303 Jan 23, 2024
@dcousens dcousens changed the title Fix failing tests for #303 Fix failing tests for #303 (unreleased) Jan 23, 2024
@LinusU
Copy link
Contributor Author

LinusU commented Jan 23, 2024

@dcousens done ✅

Copy link
Collaborator

@dcousens dcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcousens dcousens merged commit cbd0ceb into feross:master Jan 23, 2024
6 checks passed
@LinusU LinusU deleted the lu-2 branch January 23, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants