Make sure we use the standard API for file drops if it's available

[ghost]

As there are no tests, I do not know if this breaks anything. I assume the code was written so that both code path provide the same object.

The new code doesn't transform the files list to an array anymore as having a FileList instance is much more useful.

[feross]

Thanks for the PR but you bundled too many opinionated changes into one PR.

I would have merged the reversal, but I don't want to change the return type or code style.

[feross]

It wasn't necessary to change the code style here.

[ghost]

It was, a FileList isn't an array, it doesn't have a forEach method.

[feross]

Changing the return type here is a breaking change.

[ghost]

it's also the only reason to make this change, if the return type doesn't change, this library can't be used to transfer a file drag and drop to a file input

[feross]

I merged just the files vs. items change and released as 2.14.0.

[ghost]

Thanks for the PR but you bundled too many opinionated changes into one PR.

The change makes the dragDrop function return a FileList when possible, I made the minimal amount of change to make it do that. There is no opinion in there.

[feross]

@benjamin-demarteau I don't understand your use case. Can you explain it more completely?

[ghost]

I am using uppy to handle file upload, when dropping files into a drop zone, it registers the files to upload, but it doesn't add the files dropped to the html input, which means there is no user feedback (that and other problems when selecting the same file multiple times).

It is possible to add files to an input[type=file], but only if you have an instance of FileList. That restriction exists for a security reason: it makes sure you are adding files to the input based on a user interaction (FileList is not instantiable from user code).

Since uppy uses this library to handle the drag and drop events, before contributing that change, I need this library to provide a FileList to its consumers.

Reference: https://html.spec.whatwg.org/multipage/input.html#common-input-element-apis

input . files [ = files ]
Returns a FileList object listing the selected files of the form control.
Returns null if the control isn't a file control.
Can be set to a FileList object to change the selected files of the form control. For instance, as the result of a drag-and-drop operation.

[feross]

Understood. I decided to change the API to return a FileList and to drop older IE support. Published a new version as 3.0.0.

[ghost]

Thanks a bunch for this change!

[feross]

There was a regression, so I need to change the API once again. See: #39