New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _parseTags() causing error when songs are missing tags #17

Open

benpm wants to merge 3 commits into feross:master from benpm:master

benpm commented Jul 30, 2021 •

edited

Loading

Really simply fix, just making _parseTags() return an empty list when track.toptags or track.toptags.tag are missing

Edit: okay the issue i was experiencing was actually because tags.tag can sometimes be an object instead of an array of objects:

So now I've fixed _parseTags so that it can handle that

benpm added 3 commits

July 30, 2021 15:40


          fix issue with songs that dont have tags

f271147


          fixed issue where tags.tag could be not an array

0876b33


          last oopsie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet