Bring --format back #540

Closed
sheerun opened this Issue Jun 3, 2016 · 7 comments

Projects

None yet

4 participants

@sheerun
sheerun commented Jun 3, 2016

Isn't auto-formatting a free feature with new eslint? Could you bring it back to standard?

@rstacruz
Collaborator
rstacruz commented Jun 3, 2016

npmjs.com/package/standard-format

It was a very huge dependency which was wasteful when not needed. You can
still install it separately.

On Fri, Jun 3, 2016, 10:21 PM Adam Stankiewicz notifications@github.com
wrote:

Isn't auto-formatting a free feature with new eslint? Could you bring it
back to standard?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#540, or mute the thread
https://github.com/notifications/unsubscribe/AAEikbI79Oqy9_RfeboJf-wSv5iitkkcks5qIDhkgaJpZM4ItlFA
.

@sheerun
sheerun commented Jun 3, 2016

You already depend on eslint, and nowadays it has --fix flag that does exactly it. No need for extra dependencies.

@rstacruz
Collaborator
rstacruz commented Jun 3, 2016

ohh... that's a very interesting development. @feross?

@sheerun
sheerun commented Jun 3, 2016

Plesae also consider renaming it to "fix". eslint and xo already use this convention.

@Flet
Collaborator
Flet commented Jun 3, 2016

There is an issue open on standard-engine proposing that the eslint fix flag be added into it.. which could trickle down into standard

Flet/standard-engine#107

@feross
Owner
feross commented Jun 3, 2016

Yep, I'm cool with this. The right place to add it is standard-engine.

@feross
Owner
feross commented Jul 12, 2016

Sent a PR to standard-engine to implement a --fix command line flag: Flet/standard-engine#107

This will be included in the next major version release of standard.

@feross feross closed this Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment