A more correct implementation of float to string (correct except for … #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…floating point inaccuracy). The old one had numerous issues, see #183.
Fixes #183
This implementation is not perfect, but it is a heck of a lot better than what it was. I included some simple test code that shows it is correct to within rounding error.
Note that writing a dtoa function is deceptively difficult. The original author of this code does not seem to have done much testing of his overly simplistic implementation (if any). If absolute correctness to CLR specs is desired, it may be a good idea to just accept the GC cost of an intermediate string. Otherwise, this new code should be "good enough".