Support time.Time #100
Merged
Support time.Time #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
requested changes
Aug 2, 2022
sszgen/generator/unmarshal.go
Outdated
| @@ -104,6 +104,9 @@ func (v *Value) unmarshal(dst string) string { | |||
| case TypeBool: | |||
| return fmt.Sprintf("::.%s = ssz.UnmarshalBool(%s)", v.name, dst) | |||
|
|
|||
| case TypeTime: | |||
| return fmt.Sprintf("::.%s = time.Unix(int64(ssz.UnmarshallUint64(%s)), 0).UTC()", v.name, dst) | |||
There was a problem hiding this comment.
Instead of doing a complex generated code, add an entry at the root of the project with a helper function:
function UnmarshalTime(buf []byte) time.Time {
time.Unix(int64(UnmarshallUint64(buf)), 0).UTC()
}
and use that instead on the code.
There was a problem hiding this comment.
Sorry, you do not need to do this after this change.
There was a problem hiding this comment.
Should be addressed, but please take a look to confirm.
(Note that this removes the requirement for the time import in the earlier comment).
ferranbt
requested changes
Aug 2, 2022
ferranbt
approved these changes
Aug 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows encoding and decoding of the
time.Timetype in structs, touint64values.