Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip interfaces #53

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Skip interfaces #53

merged 1 commit into from
Aug 17, 2021

Conversation

ferranbt
Copy link
Owner

Closes #52.

The problem was not in the panic when encoding an interface but in selecting an interface as a target. I will leave the panic in the generation since it is useful to know if a field in the struct is valid or not.

Copy link
Contributor

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferranbt ferranbt merged commit 0cb74eb into master Aug 17, 2021
@ferranbt ferranbt deleted the skip-interfaces branch August 18, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic ast.Type *ast.Interface not expected
2 participants