Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed example numbering and description #206

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fixed example numbering and description #206

merged 1 commit into from
Apr 12, 2023

Conversation

shrugalic
Copy link
Contributor

Commit details
  • 3 no longer appears twice (the second occurrence should have been 4)
  • differentiate between no body and fully-spanning body
Optional further changes

Because I also changed the ordering of the list to be the same as the example slices in the diagram above it, it would be possible to omit the row # suffix for each item in the list.

Feel free to make this change, if you like (you could also ask me to do so, but that feels like unnecessary overhead).

Something unrelated: What's with the umlauts?

I noticed there are extra umlauts all over the place. In this particular document there are the following ones for example:

  • whatsoëver
  • reörderable
  • coëxisting

You appear to deliberately use them on vowels following another vowel, but that is non-standard in English. Additionally, as a native German speaker (who uses certain characters accented with umlauts daily), the ä, ö and ü feel just plain wrong, because those would be pronounced differently than a, o and u. (ë and ï would fine from that point of view, though still unexpected).

What's your point of view on this? I could replace them if you wanted. I assume the relevant directories would be book/ and doc/.

- 3 no longer appears twice (the second occurrence should have been 4)
- differentiate between no body and fully-spanning body
@shrugalic
Copy link
Contributor Author

About the extra umlauts issue: I just noticed that there is PR 198: Remove extra umlauts on a and e in english words that fixes this issue for two of the five vowels with extra umlauts.

@myrrlyn
Copy link
Collaborator

myrrlyn commented Apr 12, 2023

Hi! I apologize for the long delay; I have had a very stressful winter and have not had the time or energy to check this repository in a timely manner. I'm trying to catch up now.

This is why I write Like That. It's a long-running bit that I go back and forth on whether I should continue in work intended for general public consumption or not.

I do think this is a better breakdown of the diagram; thanks.

@myrrlyn myrrlyn merged commit b6650fb into ferrilab:main Apr 12, 2023
@shrugalic
Copy link
Contributor Author

Hey, I'm glad you agreed my PR was an improvement and merged it.

PS: I appreciate your reply regardless of any delay, also thanks for the link to your reasoning about our use of diæreses – very insightful.

@shrugalic shrugalic deleted the minor_documentation_fix branch April 13, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants