-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"npm run bundle" packages.json fix for windows #50
Comments
Thanks for opening this issue @richdrummer33 Do you recall what problems you had that were fixed by your changes? |
Hey there,
Yes, I had to adapt the console commands for Windows' command syntax. Once
I made those changes, everything worked as expected.
See attached!
Let me know if you need any more details on the modifications I made.
Best regards,
Richard Beare
…On Thu, Sep 7, 2023 at 11:31 PM Ferris Lucas ***@***.***> wrote:
Thanks for opening this issue @richdrummer33
<https://github.com/richdrummer33> Do you recall what problems you had
that were fixed by your changes?
—
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHXH3HWN5XDNCLSEZ6EJ7JDXZKGQ3ANCNFSM6AAAAAA4I525GA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@richdrummer33 would you mind making a pull request with your changes? |
Can do! Might later today.
…On Tue, Oct 3, 2023 at 10:23 PM Ferris Lucas ***@***.***> wrote:
@richdrummer33 <https://github.com/richdrummer33> would you mind making a
pull request with your changes?
—
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHXH3HQOI7OBK7VR3SQVHDTX5TCBXAVCNFSM6AAAAAA4I525GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWGAZDSNBQGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I didn't see a significant difference in the attached zip file. I'm probably missing something. I'm going to close this issue because it's so old, but please feel free to re-open if you get the energy to work on it. Thanks again for contributing the issue! |
package_json (win).zip
Attached zip contains a modified packages.json for windows (basically the cp command and path needed to be modified for win).
The text was updated successfully, but these errors were encountered: