-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I can't comment on the language too much, my french is rather meh.
There's some general style guide I have marked. It would be cool to try to keep individual sentences on the lines in a way that doesn't require any soft wrapping to read easily.
But this is definitely a good start!
## Focus | ||
|
||
- Rust a perdu beaucoup de features entre 2012 et 2014 | ||
- Grabarge Collector, event runtime, sytème complexe gérer les erreurs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ne connais pas beaucoup de francais, mais peut-etre que c'est un typo? :P
- Toujours avec un grand projet (ex: Servo) | ||
- Une adoption très tôt des releases régulière, depecrations et RFC processus | ||
- Bonnes methodes de developpement logiciel | ||
- "Les choses ne sont pas complètes tant qu'il n'y a plus rien à ajouter mais quand il n'y a pas plus rien à enlever." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would break this line to be shorter
|
||
--- | ||
|
||
Plusieurs exemple dans ce cours sont vraiment court, c'est pourquoi nous allons passer du temps pour discuter de l'impact plusieurs features sur des larges projets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also break this sentence
|
||
- Rust est un language basé sur les expressions. Chaques expressions a une valeur, qui peut être assignée ou retournée. | ||
|
||
- "Paye ce que tu utilise": Rust a des features qui ont un coût au runtime explicitement. Les features non utilisés ne coûte rien. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also break these sentences. Should fit into ~ 100 characters to be nicely readable without having to soft wrap
b9b10f0
to
e9bacc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missed one line break.
But apart from that, this looks good to me and can be merged afterwards 👍
## Les features du languages | ||
|
||
|
||
- Rust est un language basé sur les expressions. Chaques expressions a une valeur, qui peut être assignée ou retournée. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another line break here please
Fixed ! |
# issue 124