Liquidity Management and Cancellation of Failed Withdrawals

[raviansalman]

Overview

This pull request introduces enhancements and features to the FundManager contract for liquidity management functionality by introducing a base contract LiquidityManagerRole. Moreover, it introduces the functionality of cancellation of failed withdrawals. The notable changes include:

MultiSwap Contract Changes:

1. Base Contract: LiquidityManagerRole

   • Abstract contract providing a foundation for liquidity management roles.
   • Modifiers and functions added to set liquidity manager addresses and withdrawal address.
   • setLiquidityManagers: A setter function to set the addresses of the primary and secondary liquidity managers.
   • setLiquidityManagerWithdrawal: A setter function to set the withdrawal addresses for the liquidity manager and bot.
   • removeLiquidityByManager: A function called by onlyLiquidityManager for withdrawal of liquidity from the FundManager.
   • Introduces onlyLiquidityManager modifier for designated liquidity managers.
   • Introduced FillOrderRFQTo function in 1inchDecoder, 1inchSwap and FiberRouter contracts.

2. Derived Contract: FundManager

   • FundManager now derived from LiquidityManagerRole.
   • Specific liquidity management functions moved to LiquidityManagerRole.

3. New Modifiers:

   • onlySettlementManager: A modifier allowing only the designated settlementManager to execute certain functions. It checks if the sender is equal to the settlementManager address.

4. New Setter Function:

   • setSettlementManager: A setter function to set the address of the settlement manager.

5. New Cancel Withdrawal Functions (Settlement Engine Related):

   • cancelFailedWithdrawSigned: A function to cancel a signed token withdrawal initiated by the router. Only the settlementManager can execute this function. This helps in managing failed withdrawal transactions within the context of the settlement engine.
   • cancelFailedWithdrawSignedOneInch: A function to cancel a signed OneInch token withdrawal initiated by the router. Similar to the previous function, it's exclusive to the settlementManager and is designed to handle failed OneInch token withdrawals within the settlement engine.

6. New Event:

   • FailedWithdrawalCancelled: A new event emitted when a withdrawal is canceled. It provides information about the canceled withdrawal, including the settlement manager, recipient, token, amount, and salt.
   • Event LiquidityRemovedByManager emitted when liquidity is removed by a manager.

Additional Changes:

• Natspecs Corrections: Corrected and added NatSpec comments in the FiberRouter and FundManager contract for improved documentation and readability.
• Configuration Script: Added a new script (configContracts.js) for calling the configuration-related functions of multiswap contracts. This script facilitates the configuration process and ensures smooth interaction with the contracts.

[taha-abbasi]

@salmanferrum Let's simplify the flow by having only one withdrawal address configured. The withdrawal address is only to be configured by the owner.

Remove any logic that checks for the bot vs manager to route the withdrawal to the correct address, as this will not be needed.

We will assign the manager role to a multi-sig and the bot, so both can call the withdrawal function, and the funds will go to the single configured address.

Make sure that setLiquidityManagerWithdrawal is configurable only by owner and configurable to only one address.

[taha-abbasi]

Approved by @naiemk