-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the information in the XDMF section #801
Conversation
Thanks for this contribution @XinShen-CHN! Just letting you know that you can visualise the compiled documentation here. you can also compile the documentation locally. To do so follow the Documentation guide in the Developer’s guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 61 61
Lines 2705 2705
=======================================
Hits 2693 2693
Misses 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @XinShen-CHN for that first contribution 🎉
Here are a few remarks that would need to be addressed before merging.
@@ -62,7 +62,21 @@ The following example shows how to export the solution of a 1D problem: | |||
... | |||
|
|||
Running this should produce a file called ``mobile_conc.xdmf`` in the current directory. | |||
The file can then be opened in Paraview or any other software that can read XDMF files. | |||
The file can then be opened in Paraview or any other software that can read XDMF files. Here are some tips for using Paraview: | |||
- Make sure to have the h5 file in the same directory as the XDMF file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need one blank line to have the list correctly displayed (you can visualise the rendered results in the compiled docs).
- Make sure to have the h5 file in the same directory as the XDMF file | |
- Make sure to have the h5 file in the same directory as the XDMF file |
:width: 400 | ||
:align: center | ||
|
||
- Find out more information on `Paraview tutorials <https://www.paraview.org/tutorials/>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe another remark/tip would be to not modify the name of the files after their creation by FESTIM.
This would result in not being able to open the file in paraview because the XDMF points to the h5 file!
can you add this please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Sure, I'll modify the documentation and add the new tip.
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll leave this open a little while longer to give others a chance to make some comments and then we can merge this PR.
Proposed changes
Some updated information in the XDMF section of the documentation. #799
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist