Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the information in the XDMF section #801

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

XinShen-CHN
Copy link
Contributor

@XinShen-CHN XinShen-CHN commented Jul 6, 2024

Proposed changes

Some updated information in the XDMF section of the documentation. #799

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • [ x ] Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RemDelaporteMathurin
Copy link
Collaborator

Thanks for this contribution @XinShen-CHN!

Just letting you know that you can visualise the compiled documentation here.

you can also compile the documentation locally. To do so follow the Documentation guide in the Developer’s guide.

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (362cf71) to head (69437de).
Report is 115 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #801   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          61       61           
  Lines        2705     2705           
=======================================
  Hits         2693     2693           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XinShen-CHN for that first contribution 🎉

Here are a few remarks that would need to be addressed before merging.

@@ -62,7 +62,21 @@ The following example shows how to export the solution of a 1D problem:
...

Running this should produce a file called ``mobile_conc.xdmf`` in the current directory.
The file can then be opened in Paraview or any other software that can read XDMF files.
The file can then be opened in Paraview or any other software that can read XDMF files. Here are some tips for using Paraview:
- Make sure to have the h5 file in the same directory as the XDMF file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need one blank line to have the list correctly displayed (you can visualise the rendered results in the compiled docs).

Suggested change
- Make sure to have the h5 file in the same directory as the XDMF file
- Make sure to have the h5 file in the same directory as the XDMF file

docs/source/userguide/export_post_processing.rst Outdated Show resolved Hide resolved
:width: 400
:align: center

- Find out more information on `Paraview tutorials <https://www.paraview.org/tutorials/>`_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe another remark/tip would be to not modify the name of the files after their creation by FESTIM.

This would result in not being able to open the file in paraview because the XDMF points to the h5 file!

can you add this please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

Sure, I'll modify the documentation and add the new tip.

XinShen-CHN and others added 2 commits July 7, 2024 14:52
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll leave this open a little while longer to give others a chance to make some comments and then we can merge this PR.

@RemDelaporteMathurin RemDelaporteMathurin merged commit 1add5fc into festim-dev:main Jul 8, 2024
6 checks passed
@XinShen-CHN XinShen-CHN deleted the Update_Xin branch July 8, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the information in the XDMF section of the documentation
2 participants