Noetic tweaks #153
Merged
Noetic tweaks #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeferguson
reviewed
Jan 4, 2021
fetch_teleop/scripts/tuck_arm.py
Outdated
| move_thread = MoveItThread() | ||
| else: | ||
| prospy.loginfo("MoveIt already started...") |
There was a problem hiding this comment.
Pretty sure this is supposed to be "rospy" not "prospy"
JeffWilson7
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
lgtm
But heads up that arm tuck relies on roslaunch respawn in melodic, might have to make that change for noetic:
ZebraDevs/fetch_robots#59
|
Good catch. Tacked that fix onto this PR for noetic: ZebraDevs/fetch_robots#61 |
See fetch_ros/issues/ZebraDevs#138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixups to get things building/working on 20.04.
Also forward-ports #150