Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic tweaks #153

Merged
merged 8 commits into from
Feb 28, 2021
Merged

Noetic tweaks #153

merged 8 commits into from
Feb 28, 2021

Conversation

erelson
Copy link
Collaborator

@erelson erelson commented Jan 4, 2021

Minor fixups to get things building/working on 20.04.

Also forward-ports #150

@erelson erelson requested a review from a team as a code owner January 4, 2021 06:27
@erelson erelson self-assigned this Jan 4, 2021
move_thread = MoveItThread()
else:
prospy.loginfo("MoveIt already started...")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is supposed to be "rospy" not "prospy"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 thanks!

Copy link
Contributor

@cjds cjds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from prospy lgtm

Copy link

@JeffWilson7 JeffWilson7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

But heads up that arm tuck relies on roslaunch respawn in melodic, might have to make that change for noetic:
ZebraDevs/fetch_robots#59

@erelson
Copy link
Collaborator Author

erelson commented Jan 4, 2021

Good catch. Tacked that fix onto this PR for noetic: ZebraDevs/fetch_robots#61

@erelson erelson merged commit 201f855 into ZebraDevs:ros1 Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants