Fixed some wrong comparisons

feup-infolab · Jun 15, 2017 · 880006e · 880006e
1 parent 9e929ce
commit 880006e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/.idea/jsLibraryMappings.xml b/.idea/jsLibraryMappings.xml
diff --git a/src/controllers/files.js b/src/controllers/files.js
@@ -623,8 +623,8 @@ exports.upload = function(req, res)
     if (req.originalMethod === "GET")
     {
         if (
-            typeof upload_id !== "undefined" &&
-            typeof upload_id !== "" &&
+            !isNull(upload_id) &&
+            upload_id !== "" &&
             !isNull(username)
         )
         {
@@ -938,7 +938,7 @@ exports.upload = function(req, res)
             }
         };
 
-        if (typeof typeof upload != null)
+        if (!isNull(upload))
         {
             const multiparty = require('multiparty');
             const form = new multiparty.Form({maxFieldSize: 8192, maxFields: 10, autoFiles: false});

diff --git a/src/kb/db.js b/src/kb/db.js
@@ -427,7 +427,7 @@ DbConnection.addLimitsClauses = function(query, offset, maxResults)
 DbConnection.pushLimitsArguments = function(unpaginatedArgumentsArray, maxResults, offset)
 {
     if(!isNull(offset) &&
-        typeof offset === "int" &&
+        typeof offset === "number" &&
         offset > 0)
     {
         unpaginatedArgumentsArray = unpaginatedArgumentsArray.push({
@@ -437,7 +437,7 @@ DbConnection.pushLimitsArguments = function(unpaginatedArgumentsArray, maxResult
     }
 
     if(!isNull(maxResults) &&
-        typeof maxResults === "int" &&
+        typeof maxResults === "number" &&
         maxResults > 0)
     {
         unpaginatedArgumentsArray = unpaginatedArgumentsArray.push({

diff --git a/src/models/directory_structure/file.js b/src/models/directory_structure/file.js
@@ -685,7 +685,7 @@ File.createBlankFileRelativeToAppRoot = function(relativePathToFile, callback)
     fs.stat(absPathToFile, function(err, stat) {
         if(isNull(err)) {
             callback(0, absPathToFile, parentFolder);
-        } else if(typeof err.code === 'ENOENT') {
+        } else if(err.code === 'ENOENT') {
             // file does not exist
             const mkpath = require('mkpath');