Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass children to templates onUpdate function in second arg #6

Open
fewkz opened this issue Oct 3, 2022 · 1 comment
Open

Pass children to templates onUpdate function in second arg #6

fewkz opened this issue Oct 3, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request not sure

Comments

@fewkz
Copy link
Owner

fewkz commented Oct 3, 2022

We should probably do the same thing for templates, by passing a second arg to the onUpdate callback functions with the children

Originally posted by @fewkz in #4 (comment)

@fewkz
Copy link
Owner Author

fewkz commented Apr 26, 2023

i'm so confused how would this would even work for templates... they are instance-based, would the "children" be instances or elements? idk why I made this issue.
The way I could see this working is it passes the elements to the onUpdate function, and the template would be responsible for doing froact.Roact.mount, froact.Roact.update, and froact.Roact.unmount.

@fewkz fewkz self-assigned this May 1, 2023
@fewkz fewkz added enhancement New feature or request not sure labels May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not sure
Projects
None yet
Development

No branches or pull requests

1 participant