Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add angular example #653

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Add angular example #653

merged 1 commit into from
Dec 17, 2023

Conversation

jeromewu
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Dec 17, 2023

Deploy Preview for ffmpegwasm ready!

Name Link
🔨 Latest commit 5495df9
🔍 Latest deploy log https://app.netlify.com/sites/ffmpegwasm/deploys/657e8f8e2cf0a40008feead3
😎 Deploy Preview https://deploy-preview-653--ffmpegwasm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jeromewu jeromewu merged commit 623dd12 into main Dec 17, 2023
7 checks passed
@sp90
Copy link

sp90 commented Dec 21, 2023

@jeromewu I tried doing exactly what you do here with angular in the same version, i also copied this example out and it returns a vite error which I think might be an error in the worker but I could be wrong:

Let me know if I'm doing something wrong, I also tried to install core-mt and use angular.json to copy the files to /assets/ffmpeg and then set that to baseUrl both fail though

I don't get any load errors if I try to catch the await ffmpeg.load(...)

Screenshot 2023-12-21 at 13 38 11

My gut tells me it's because the worker in the browser is not supporting the node-related
code in there like var fs = require("fs") But I guess this should fail in all browser implementations

The issue persists on the playground page:

https://ffmpegwasm.netlify.app/playground/

@leoffx
Copy link

leoffx commented Dec 23, 2023

I'm having the same error, also in my personal project. It might be related to the new Angular 17 version, but I couldn't figure out how to fix it yet.

@stefdelec
Copy link

stefdelec commented Apr 23, 2024

Same error here.
I tried to put worker in "asset" dir and then update

    await this.ffmpeg.load({
        coreURL: await toBlobURL(`${baseURL}/ffmpeg-core.js`, "text/javascript"),
        wasmURL: await toBlobURL(
          `${baseURL}/ffmpeg-core.wasm`,
          "application/wasm"
        ),
        workerURL: await toBlobURL(
          `${baseURL}/ffmpeg-core.worker.js`,
          "text/javascript"
        ),
        classWorkerURL: 'http://localhost:4200/assets/worker.js'
      });

I don't have error but still not working. It never stops loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants