Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Google Translate API integrated #18

Closed
wants to merge 17 commits into from
Closed

Google Translate API integrated #18

wants to merge 17 commits into from

Conversation

chankruze
Copy link
Contributor

It is simplified now.You should review the code & i think this is mergable.

@chankruze
Copy link
Contributor Author

chankruze commented May 13, 2018

Hi @mwarning i am just informing you that
I used js to add Google Translate API in both pull request #17 & #18 but i closed #17 because i found it will be more informative if i include the function in shared.js.

There is no conflict with this code therefore i am asking to review and merge it.It will be very helpful for non german users to understant web interface.

@mwarning
Copy link
Contributor

hi @geekofia, thanks for your effort. I need to think about a solution here. The problem is, that the router is expected to work without Internet access. This makes it desirable to have translations working without Internet access.

@chankruze
Copy link
Contributor Author

First of all thanks for reviewing.You have a solid point.I will think a solution for it.

@chankruze chankruze closed this May 15, 2018
@chankruze
Copy link
Contributor Author

I think now only solution is to save translations to a variable in separate js file. We can call a function with event listener to change language on click.

@mwarning
Copy link
Contributor

I agree.

@chankruze
Copy link
Contributor Author

Is some one working on multi language support ? Or i should start working ?

@mwarning
Copy link
Contributor

mwarning commented Jun 9, 2018

hi @geekofia, I forgot about this ticket. Sorry about that.
How about something like this: freifunk-bielefeld/firmware@d013faa

It's really simple but might work. Translations are not integrated yet.
The language of the default text could be english.

@chankruze
Copy link
Contributor Author

Yes that should work.Need the whole lines to be translated.I have translated them.If need you can comment.

@mwarning
Copy link
Contributor

I think it is better to translate the whole lines.
Can you do a pull request with the translations?
Then I can merge them. :-)

@chankruze
Copy link
Contributor Author

please see closed pull request #16.And let me know is that what you need or anything else ?

@mwarning
Copy link
Contributor

mwarning commented Jun 11, 2018

The data is all there. But it need to be put together :-)
The branch from #16 is not available anymore. So this will be a lot of manual work.

@chankruze
Copy link
Contributor Author

I am translating (like #16), clean forked and if i translate the german lines to english in html and js (help texts) ..then the german will be replaced with english ... is it okay ?

@mwarning
Copy link
Contributor

mwarning commented Jun 11, 2018

That would be great! Anyway, time for me to go to bed now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants