Skip to content
This repository has been archived by the owner on Jan 6, 2020. It is now read-only.

use 32-bit ints for values, add NaN tagging #21

Open
wants to merge 19 commits into
base: haru
Choose a base branch
from
Open

Conversation

ffwff
Copy link
Owner

@ffwff ffwff commented Jun 3, 2019

fixes #18

@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (haru@ac5d6b8). Click here to learn what that means.
The diff coverage is 80.67%.

Impacted file tree graph

@@           Coverage Diff           @@
##             haru      #21   +/-   ##
=======================================
  Coverage        ?   84.62%           
=======================================
  Files           ?       32           
  Lines           ?     2816           
  Branches        ?        0           
=======================================
  Hits            ?     2383           
  Misses          ?      433           
  Partials        ?        0
Impacted Files Coverage Δ
src/hanayo/time.rs 0% <0%> (ø)
src/vmbindings/function.rs 100% <100%> (ø)
src/vmbindings/value.rs 94.44% <100%> (ø)
tests/interpreter.rs 95% <100%> (ø)
src/vm/value.h 100% <100%> (ø)
src/hanayo/proc.rs 71.66% <100%> (ø)
tests/hanayo.rs 99.63% <100%> (ø)
src/vmbindings/gc.rs 83.7% <100%> (ø)
src/vmbindings/record.rs 95.65% <100%> (ø)
src/hanayo/int.rs 96.55% <100%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac5d6b8...2c82943. Read the comment docs.

@ffwff ffwff marked this pull request as ready for review June 4, 2019 00:16
@ffwff ffwff added the regression Patch causes performance regression label Jun 4, 2019
@ffwff
Copy link
Owner Author

ffwff commented Jun 4, 2019

I've decided not to merge this due to a significant performance regression (benchmarks are 10-15% slower, however it consumes 10% less memory)

If anyone can find a way to fix this regression, please comment here.

ffwff added a commit that referenced this pull request Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression Patch causes performance regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use NaN-tagging to store native values
2 participants