This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
use 32-bit ints for values, add NaN tagging #21
Open
ffwff
wants to merge
19
commits into
haru
Choose a base branch
from
nan-tagging
base: haru
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## haru #21 +/- ##
=======================================
Coverage ? 84.62%
=======================================
Files ? 32
Lines ? 2816
Branches ? 0
=======================================
Hits ? 2383
Misses ? 433
Partials ? 0
Continue to review full report at Codecov.
|
I've decided not to merge this due to a significant performance regression (benchmarks are 10-15% slower, however it consumes 10% less memory) If anyone can find a way to fix this regression, please comment here. |
ffwff
added a commit
that referenced
this pull request
Jun 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18