Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs about changing broker address via env var #87

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Add docs about changing broker address via env var #87

merged 1 commit into from
Oct 25, 2018

Conversation

empeje
Copy link
Contributor

@empeje empeje commented Oct 15, 2018 •
edited
Loading

I look for the docs, and nothing found so I search through the code and try myself, I decided to create a PR for docs improvement.

fgeller
fgeller approved these changes Oct 25, 2018
View reviewed changes
Copy link
Owner

@fgeller fgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for that ! will pull it in and add a bit more info

@fgeller fgeller merged commit 68132b9 into fgeller:master Oct 25, 2018
@empeje
Copy link
Contributor Author

empeje commented Oct 26, 2018

my pleasure, I like your tool 👍 @fgeller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgeller fgeller fgeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@empeje @fgeller