Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in javascript function p5get_class_for_method #14

Merged
merged 2 commits into from
Oct 24, 2012
Merged

Bug in javascript function p5get_class_for_method #14

merged 2 commits into from
Oct 24, 2012

Conversation

atoy40
Copy link

@atoy40 atoy40 commented Oct 22, 2012

The recursive call to p5get_class_for_method doesn't propagate the "seen" Array, so it generate a javascript exception if you've a @isa hierarchy with more than 2 classes. (there is 2 commits, one for the fix in Runtime(s).pm and one with the perlito5.pl compiler bootstraped)

Anthony.

fglock added a commit that referenced this pull request Oct 24, 2012
Bug in javascript function p5get_class_for_method
@fglock fglock merged commit a96fa40 into fglock:master Oct 24, 2012
@fglock
Copy link
Owner

fglock commented Oct 24, 2012

applied, thanks!

2012/10/22 Anthony Hinsinger notifications@github.com

The recursive call to p5get_class_for_method doesn't propagate the "seen"
Array, so it generate a javascript exception if you've a @isahttps://github.com/ISAhierarchy with more than 2 classes. (there is 2 commits, one for the fix in
Runtime(s).pm and one with the perlito5.pl compiler bootstraped)

Anthony.

You can merge this Pull Request by running:

git pull https://github.com/atoy40/Perlito master

Or view, comment on, or merge it at:

#14
Commit Summary

  • Fixed a bug in javascript function p5get_class_for_method
  • Re-bootstrap perlito5.pl with javascript bug fixed

File Changes

  • M perlito5.pl (4)
  • M src5/lib/Perlito5/Javascript2/Runtime.pm (2)
  • M src5/lib/Perlito5/Javascript3/Runtime.pm (2)

Patch Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants